Skip to content

Fixes a couple of flaky unit and UI tests #19750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2022
Merged

Fixes a couple of flaky unit and UI tests #19750

merged 3 commits into from
Dec 11, 2022

Conversation

@hassaanelgarem
Copy link
Contributor

@hassaanelgarem hassaanelgarem commented Dec 8, 2022 •
edited
Loading

Description

This PR fixes a couple of flaky unit and UI tests.
Tests targeted are the least reliable tests based on Buildkite's test analytics.

Targeted tests:

  • MediaURLExporterTests.testThatURLExportingVideoWorks
  • MediaURLExporterTests.testThatURLExportingVideoWithoutGPSWorks
  • EditorGutenbergTests.testAddGalleryBlock

Testing Instructions

No need for testing. If the CI passes, then we're good to go

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added [Type] Enhancement Testing Unit and UI Tests and Tooling labels Dec 8, 2022
@hassaanelgarem hassaanelgarem added this to the 21.4 milestone Dec 8, 2022
@hassaanelgarem hassaanelgarem requested a review from a team as a code owner December 8, 2022 02:00
@hassaanelgarem hassaanelgarem self-assigned this Dec 8, 2022
@hassaanelgarem hassaanelgarem changed the title Fix/flaky tests Fixes a couple of flaky unit and UI tests Dec 8, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 8, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 8, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19750-a7fa7d6 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 8, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19750-a7fa7d6 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

jostnes
jostnes reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@jostnes jostnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at making UI tests more reliable @hassaanelgarem ! I'm not too sure which tests this is looking to fix exactly but from the list here and the changes made, I'm thinking it's testAddGalleryBlock but please let me know if that's not it.

I have one comment but other than that it should be good!

@hassaanelgarem
Copy link
Contributor Author

hassaanelgarem commented Dec 8, 2022

I'm not too sure which tests this is looking to fix exactly but from the list here and the changes made, I'm thinking it's testAddGalleryBlock but please let me know if that's not it.

@jostnes Yeah sorry about that. You're correct. I've updated the PR description with the targeted tests 👍

jostnes
jostnes approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@jostnes jostnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the description, the test looks good! :shipit:

@hassaanelgarem hassaanelgarem merged commit fcd3459 into trunk Dec 11, 2022
@hassaanelgarem hassaanelgarem deleted the fix/flaky-tests branch December 11, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jostnes jostnes jostnes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hassaanelgarem hassaanelgarem

Labels

Testing Unit and UI Tests and Tooling [Type] Enhancement

Projects

None yet

Milestone

21.4

Development

Successfully merging this pull request may close these issues.

4 participants

@hassaanelgarem @wpmobilebot @jostnes